WIP: feat/20-reactions-for-roles #59
No reviewers
Labels
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
hackser/jellyfin-discord-bot!59
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "feat/20-reactions-for-roles"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
solves #20
@ -0,0 +41,4 @@.catch(error => {logger.error(`Could not find announcement_role with id ${config.bot.announcement_role}. Error: ${error}`, { requestId, guildId: guild.id })throw error})method called reactions but parameter is singular
1f372b0aac@ -0,0 +47,4 @@}public async assignAnnouncementRolesFromReaction(guild: Guild, reaction: MessageReaction, requestId: string) {const guildId = guild.idadd error to previous line to be consistent with rest of class. Also maybe put checking to getAnnouncementRoleForGuild, so calling methods can rely on the role to be there?
a50ac1716few, a THIRD "not there" type??? wth
a60fc2db7eNo longer necessary after refactoring of announcementrole fetching
a50ac1716fNice work only minor comments from me so far. Great to have a controller for roles now
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.Merge
Merge the changes and update on Forgejo.Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.